Merge jobs in C-ACI CI #6363
Merged
Merge jobs in C-ACI CI #6363
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eddyashton
approved these changes
Jul 15, 2024
|
Confirmed manually on this run that a job cancelation happening during CTest will not result in a leaked container. |
|
Test failure unrelated to PR change, logged as #6372 |
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is unclear why the jobs were split, perhaps they used to be run in different pools. Other than verbosity, the problem with the current layout is that the cancelation of a job half-way through, for example due to a more recent commit, can result in the ACI container failing to be shut down.
The goal remains to move the contents of this job to a hosted pool, when the necessary features become available, but for the time being, this change aims to reduce the amount of containers that leak out of this pipeline.